[system] Refactor sortContainerQueries to define regex outside of sort function#47817
Merged
Conversation
Netlify deploy previewhttps://deploy-preview-47817--material-ui.netlify.app/ Bundle size report
|
zannager
added
the
scope: system
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors sortContainerQueries in cssContainerQueries.ts to avoid re-creating the same RegExp on every sort comparator call, keeping behavior the same while reducing per-iteration work.
Changes:
- Hoists the
min-widthmatchingRegExpout of the.sort()callback insortContainerQueries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
siriwatknp
reviewed
Mar 2, 2026
siriwatknp
left a comment
siriwatknp
left a comment
Member
There was a problem hiding this comment.
how about moving it outside of the function to avoid recreating on every call?
siriwatknp
approved these changes
Mar 2, 2026
siriwatknp
left a comment
siriwatknp
left a comment
Member
There was a problem hiding this comment.
👍 I'll let you decide on my comment
Member
Author
|
Interestingly moving regex outside of function increased bundle-size by good amount, so For now i'm just going with keeping regex inside function but out of loop 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the
sortContainerQueriesfunction incssContainerQueries.tsby moving theregexdeclaration outside of the sorting callback as it's not required to create regex on every loop