[checkbox group][radio group] Forward group ids#4997
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,338.10 ms +59.70 ms(+4.7%) | Renders: 50 (+0) | Paint: 2,002.82 ms +60.93 ms(+3.1%)
9 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review (GPT-5.5)Approve ✅ The group 1. Bugs / Issues (None)I didn’t find any blocking or non-blocking issues in the branch diff. 2. Root Cause & Patch AssessmentBoth groups already consumed 3. Test Coverage AssessmentThe added tests cover the public behavior directly for both affected components by rendering each group with an explicit |
idprops on CheckboxGroup and RadioGroup were consumed for field registration and never reached the rendered group element.Root cause
Both groups destructured
idbefore spreading element props and did not add it back to the root props.Changes
idprop to the CheckboxGroup root.idprop to the RadioGroup root.