Skip to content

[field] Fix valueMissing revalidation#4995

Open
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/field-value-missing-revalidation
Open

[field] Fix valueMissing revalidation#4995
atomiks wants to merge 1 commit into
mui:masterfrom
atomiks:codex/field-value-missing-revalidation

Conversation

@atomiks

@atomiks atomiks commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

A required field could keep showing a stale native validation state after a previous native error changed into a required error.

Root cause

isOnlyValueMissing() reset its flag during the valueMissing check, so it never allowed value-missing-only revalidation to continue.

Changes

  • Fixed the helper to only clear the flag for other validity errors.
  • Added coverage for clearing an invalid email field into a required-empty field.

@atomiks atomiks added component: field Changes related to the field component. type: bug It doesn't behave as expected. labels Jun 10, 2026 — with ChatGPT Codex Connector
@pkg-pr-new

pkg-pr-new Bot commented Jun 10, 2026

Copy link
Copy Markdown

commit: 361906c

@code-infra-dashboard

code-infra-dashboard Bot commented Jun 10, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react ▼-3B(0.00%) 🔺+2B(0.00%)

Details of bundle changes

Performance

Total duration: 1,232.63 ms +41.88 ms(+3.5%) | Renders: 50 (+0) | Paint: 1,869.86 ms +88.61 ms(+5.0%)

Test Duration Renders
Select mount (200 instances) 157.92 ms 🔺+26.36 ms(+20.0%) 3 (+0)
Select open (500 options) 70.50 ms 🔺+20.53 ms(+41.1%) 14 (+0)

10 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 361906c
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a290d605a3cae00085bcb77
😎 Deploy Preview https://deploy-preview-4995--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks marked this pull request as ready for review June 10, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: field Changes related to the field component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant