Skip to content

[popups] Use popup-backed floating context#4973

Draft
michaldudak wants to merge 10 commits into
mui:masterfrom
michaldudak:codex/store-refactoring
Draft

[popups] Use popup-backed floating context#4973
michaldudak wants to merge 10 commits into
mui:masterfrom
michaldudak:codex/store-refactoring

Conversation

@michaldudak

Copy link
Copy Markdown
Member

Summary

  • Replace mirrored floating root stores with popup-backed floating context adapters across the migrated popup components.
  • Keep the floating context in store context while deriving open, refs, IDs, and transition state from the popup store.
  • Fix StoreInspector serialization for popup contexts with circular back-references.
  • Fix modal initial-focus timing so outside content is not aria-hidden while the trigger still has focus.

Verification

  • Manual Chrome pass on docs experiments for Menu, Popover, Dialog, Tooltip, and PreviewCard.
  • pnpm test:jsdom FloatingFocusManager --no-watch
  • pnpm test:chromium FloatingFocusManager --no-watch
  • pnpm test:jsdom DialogPopup --no-watch
  • pnpm test:jsdom StoreInspector --no-watch
  • pnpm test:jsdom PopupFloatingRootContext --no-watch
  • pnpm typescript
  • targeted pnpm eslint

@pkg-pr-new

pkg-pr-new Bot commented Jun 4, 2026

Copy link
Copy Markdown

commit: 48be362

@code-infra-dashboard

code-infra-dashboard Bot commented Jun 4, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 🔺+4.07KB(+0.87%) 🔺+861B(+0.58%)

Details of bundle changes

Performance

Total duration: 1,222.29 ms -57.08 ms(-4.5%) | Renders: 50 (+0) | Paint: 1,878.40 ms -42.17 ms(-2.2%)

Test Duration Renders
Menu open (500 items) 92.13 ms 🔺+18.48 ms(+25.1%) 12 (+0)

11 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Jun 4, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 48be362
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a218d8463c03500083d8ac3
😎 Deploy Preview https://deploy-preview-4973--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant