[combobox] Fix autofill and selected state edge cases#4972
Draft
atomiks wants to merge 3 commits into
Draft
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,263.23 ms -152.66 ms(-10.8%) | Renders: 50 (+0) | Paint: 1,893.10 ms -243.08 ms(-11.4%)
7 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Codex sweep. Ports the Select autofill and selected-state fixes (#4934) to Combobox, with the review findings from that port folded in.
Changes
value="US">United Statesautofills correctly. Works for inline children and theitemsprop.useValueChangedeffects and respectsonValueChange/onInputValueChangecancellation. A canceled autofill, selection, or input change no longer touches field state, and a canceled single selection keeps the popup open.data-dirtywhen the value returns to its initial set, comparing element-by-element with the item comparator instead of by array reference.aria-controlspoints at the dialog popup (a stable${rootId}-popupid shared by the popup and trigger) instead of the listbox.Combobox.Labelresolves toCombobox.Label.Statein the generated docs.Original findings addressed
${rootId}-popupid was built in both the popup and the trigger; it's now onegetComboboxPopupIdhelper, with the custom-id path covered.forceMountedmount was sticky and ran formultipleandnonemodes that never match; it's now scoped to single-selection autofill.