[combobox] Add SelectAll part for multiple selection#4962
Draft
soheilnikroo wants to merge 2 commits into
Draft
Conversation
Adds Combobox.SelectAll to toggle all currently filtered items in multiple mode, with tests and a docs demo. Co-authored-by: Cursor <cursoragent@cursor.com>
soheilnikroo
requested review from
aarongarciah,
atomiks,
colmtuite,
flaviendelangle and
michaldudak
as code owners
commit: |
Bundle size
PerformanceTotal duration: 1,451.99 ms +241.22 ms(+19.9%) | Renders: 50 (+0) | Paint: 2,165.87 ms +320.56 ms(+17.4%)
…and 2 more (+5 within noise) — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Updates autogenerated types.md and component index for Combobox.SelectAll and the select-all-press change event reason. Co-authored-by: Cursor <cursoragent@cursor.com>
aarongarciah
added
type: new feature
Member
|
Let's settle the discussion on the issue before continuing the work here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Combobox.SelectAll to toggle all currently filtered items in multiple mode, with tests and a docs demo.
Resolve #4927