Skip to content

[code-infra] Remove examples from pnpm workspace#4759

Merged
Janpot merged 4 commits into
mui:masterfrom
Janpot:remove-examples-workspace
Jun 9, 2026
Merged

[code-infra] Remove examples from pnpm workspace#4759
Janpot merged 4 commits into
mui:masterfrom
Janpot:remove-examples-workspace

Conversation

@Janpot

@Janpot Janpot commented May 7, 2026

Copy link
Copy Markdown
Member

Removes examples/* from pnpm-workspace.yaml so the example apps are no longer installed as workspace packages. As they're meant to be copied by users, we can't declare our dependencies as workspace:*. Making the workspace a bit less useful.

At the moment these are inflating our dependencies and since they're not tracked by renovatebot, they cause drift and weird peer dependency deduplication issues.

See also https://app.notion.com/p/mui-org/Examples-folders-373cbfe7b66080168f9fda1cf5fa60ed

@pkg-pr-new

pkg-pr-new Bot commented May 7, 2026

Copy link
Copy Markdown

commit: 18356d4

@code-infra-dashboard

code-infra-dashboard Bot commented May 7, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,237.69 ms -136.30 ms(-9.9%) | Renders: 50 (+0) | Paint: 1,846.48 ms -228.50 ms(-11.0%)

Test Duration Renders
Menu open (500 items) 67.98 ms ▼-21.25 ms(-23.8%) 12 (+0)

11 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented May 7, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 18356d4
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6a27c581a3c8a70008f63e93
😎 Deploy Preview https://deploy-preview-4759--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label May 7, 2026
@Janpot Janpot marked this pull request as ready for review May 7, 2026 10:43
@oliviertassinari oliviertassinari changed the title [infra] Remove examples from pnpm workspace [code-infra] Remove examples from pnpm workspace May 8, 2026
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 14, 2026
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 9, 2026
@Janpot Janpot requested a review from a team June 9, 2026 14:04
@Janpot Janpot merged commit d0a1abe into mui:master Jun 9, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants