Skip to content

[code-infra] Replace markdownlint-cli2 with eslint-plugin-mdx#4697

Merged
Janpot merged 2 commits into
mui:masterfrom
Janpot:code-infra/eslint-markdown
May 6, 2026
Merged

[code-infra] Replace markdownlint-cli2 with eslint-plugin-mdx#4697
Janpot merged 2 commits into
mui:masterfrom
Janpot:code-infra/eslint-markdown

Conversation

@Janpot

@Janpot Janpot commented Apr 28, 2026

Copy link
Copy Markdown
Member

Mirrors mui/material-ui#48371. Drops markdownlint-cli2 in favor of remark-based linting via eslint-plugin-mdx, wired through @mui/internal-code-infra.

@pkg-pr-new

pkg-pr-new Bot commented Apr 28, 2026

Copy link
Copy Markdown

commit: f9594de

@code-infra-dashboard

code-infra-dashboard Bot commented Apr 28, 2026

Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,272.24 ms ▼-258.41 ms(-16.9%) | Renders: 53 (+0) | Paint: 1,973.18 ms ▼-368.61 ms(-15.7%)

Test Duration Renders
Checkbox mount (500 instances) 72.68 ms 🔺+2.75 ms(+3.9%) 1 (+0)
Tabs mount (200 instances) 231.16 ms ▼-84.07 ms(-26.7%) 4 (+0)
Menu mount (300 instances) 135.31 ms ▼-38.57 ms(-22.2%) 2 (+0)
Scroll Area mount (300 instances) 85.96 ms ▼-24.51 ms(-22.2%) 3 (+0)
Popover mount (300 instances) 100.52 ms ▼-22.43 ms(-18.2%) 2 (+0)

…and 7 more — details


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Apr 28, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit f9594de
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69f9f6df07c09e00088b60eb
😎 Deploy Preview https://deploy-preview-4697--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Apr 29, 2026
@github-actions github-actions Bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Apr 29, 2026
@Janpot Janpot force-pushed the code-infra/eslint-markdown branch from 61e2b21 to 770e5ed Compare May 5, 2026 11:27
@github-actions github-actions Bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels May 5, 2026
@Janpot Janpot force-pushed the code-infra/eslint-markdown branch from 770e5ed to f9594de Compare May 5, 2026 13:55
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 5, 2026
@Janpot Janpot marked this pull request as ready for review May 5, 2026 15:16

@LukasTy LukasTy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, very clean solution. 👍

However, is it expected that the runtime is ~4x slower (2min instead of 30s)?

I assume it's running on the whole codebase every time, whereas the previous solution probably ran only on the diff?

@Janpot

Janpot commented May 5, 2026

Copy link
Copy Markdown
Member Author

However, is it expected that the runtime is ~4x slower (2min instead of 30s)?

I assume it's running on the whole codebase every time, whereas the previous solution probably ran only on the diff?

Likely the cache was busted. A rerun does it in 16s.

@LukasTy LukasTy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, is it expected that the runtime is ~4x slower (2min instead of 30s)?
I assume it's running on the whole codebase every time, whereas the previous solution probably ran only on the diff?

Likely the cache was busted. A rerun does it in 16s.

Nice, then it's both cleaner and faster. 👏

@Janpot Janpot merged commit 77f298d into mui:master May 6, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants