[select] Fix highlightItemOnHover not being respected#3868
Merged
LukasTy merged 1 commit intoJan 27, 2026
Merged
Conversation
Bundle size report
Check out the code infra dashboard for more information about this PR. |
highlightItemOnHover false not being respected
Contributor
Greptile OverviewGreptile SummaryFixed
Confidence Score: 5/5
Important Files Changed
|
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
950f581 to
244a189
Compare
highlightItemOnHover false not being respectedhighlightItemOnHover false not being respected
commit: |
244a189 to
a280a05
Compare
highlightItemOnHover false not being respectedhighlightItemOnHover not being respected
a280a05 to
5ce9550
Compare
LukasTy
approved these changes
Jan 27, 2026
LukasTy
left a comment
Member
There was a problem hiding this comment.
Nice attention to detail. 👍
Thank you for fixing this issue. 🙏
atomiks
pushed a commit
to atomiks/base-ui
that referenced
this pull request
Jan 28, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
highlightItemOnHoverisfalse,data-highlightedshould not be applied toSelect.Item's. Adding condition toonMouseEnterfixes it.Unit tests did not fail as they were using
fireEvent.mouseMove,UserEventshould triggermouseEnterandmouseMove.Fixes #3867