[combobox] Fix the type of the ref of the Icon part

[flaviendelangle]

Fixes #3790

We have a some components the use HTMLElement instead of the exact typing, which most of them use the exact typing (HTMLDivElement, HTMLSpanElement, etc...)

Is there a reason to have this distinction?

File	Current Ref Type	Rendered Element	Should Be
packages/react/src/button/Button.tsx	HTMLElement	button	HTMLButtonElement
packages/react/src/checkbox/root/CheckboxRoot.tsx	HTMLElement	span	HTMLSpanElement
packages/react/src/radio/root/RadioRoot.tsx	HTMLElement	span	HTMLSpanElement
packages/react/src/switch/root/SwitchRoot.tsx	HTMLElement	span	HTMLSpanElement
packages/react/src/tabs/tab/TabsTab.tsx	HTMLElement	button	HTMLButtonElement
packages/react/src/accordion/trigger/AccordionTrigger.tsx	HTMLElement	button	HTMLButtonElement
packages/react/src/popover/trigger/PopoverTrigger.tsx	HTMLElement	button	HTMLButtonElement
packages/react/src/menu/item/MenuItem.tsx	HTMLElement	div	HTMLDivElement
packages/react/src/menu/checkbox-item/MenuCheckboxItem.tsx	HTMLElement	div	HTMLDivElement
packages/react/src/menu/radio-item/MenuRadioItem.tsx	HTMLElement	div	HTMLDivElement
packages/react/src/menu/submenu-trigger/MenuSubmenuTrigger.tsx	HTMLElement	div	HTMLDivElement
packages/react/src/select/item/SelectItem.tsx	HTMLElement	div	HTMLDivElement

[pkg-pr-new]

• vite-css-base-ui-example

  pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3796
  

  pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3796
  

commit: 135eddc

[netlify]

✅ Deploy Preview for base-ui ready!

Name	Link
🔨 Latest commit	135eddc
🔍 Latest deploy log	https://app.netlify.com/projects/base-ui/deploys/696f5311981f2400085ccf8a
😎 Deploy Preview	https://deploy-preview-3796--base-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[mui-bot]

Bundle size report

Bundle	Parsed size	Gzip size
@base-ui/react	0B(0.00%)	0B(0.00%)

Details of bundle changes

---

Check out the code infra dashboard for more information about this PR.

[greptile-apps]

Greptile Summary

Fixed the ref type for Combobox.Icon from HTMLDivElement to HTMLSpanElement to correctly match the rendered element type.

• Changed forwardedRef parameter type in ComboboxIcon.tsx:12 from React.ForwardedRef<HTMLDivElement> to React.ForwardedRef<HTMLSpanElement>
• The component renders a <span> element (line 16) and its props type already correctly specified BaseUIComponentProps<'span', ...> (line 32)
• This aligns with existing test expectations (refInstanceof: window.HTMLSpanElement in ComboboxIcon.test.tsx:8)
• Follows the same pattern used by other icon components like SelectIcon that also render <span> elements

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The change is a straightforward type correction that fixes a mismatch between the ref type and the actual rendered element. The fix aligns with existing test expectations, matches the pattern used by similar components, and makes the types consistent across the component definition.
• No files require special attention

Important Files Changed

Filename	Overview
packages/react/src/combobox/icon/ComboboxIcon.tsx	Fixed ref type from HTMLDivElement to HTMLSpanElement to match the rendered element and component props type

[greptile-apps]

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

_{This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".}

[flaviendelangle]

I noticed those two other inconsistencies that only impact the JSDoc

[atomiks]

We have a some components the use HTMLElement instead of the exact typing, which most of them use the exact typing (HTMLDivElement, HTMLSpanElement, etc...)

Is there a reason to have this distinction?

Some of my reasoning in this PR #3638. Depends if it's likely to be polymorphic or not. Though for typesafety, the ref can be attached to the rendered element itself anyway: <Button ref={buttonRef} render={<div ref={divRef} />} />

[flaviendelangle]

@atomiks thats what I thought, thanks for the confirmation 🙏