Skip to content

[internal] Iterate on resolveMultipleLabels in one loop#3709

Merged
michaldudak merged 1 commit into
mui:masterfrom
oliviertassinari:bundle-size-select
Jan 9, 2026
Merged

[internal] Iterate on resolveMultipleLabels in one loop#3709
michaldudak merged 1 commit into
mui:masterfrom
oliviertassinari:bundle-size-select

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Jan 9, 2026

Copy link
Copy Markdown
Member

Iterate on #3314.

Use a bit fewer byles:
SCR-20260109-kxnx

and fewer CPU cycles by moving from looping twice on the data to once. It's a classic performance win that Romain had a lot of success with on the data grid codebase.

@oliviertassinari oliviertassinari added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. internal Behind-the-scenes enhancement. Formerly called “core”. labels Jan 9, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jan 9, 2026

Copy link
Copy Markdown
  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3709
    
    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3709
    

commit: fe36c1d

@mui-bot

mui-bot commented Jan 9, 2026

Copy link
Copy Markdown

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react ▼-21B(-0.01%) ▼-7B(-0.01%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify

netlify Bot commented Jan 9, 2026

Copy link
Copy Markdown

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit fe36c1d
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6960d633d0959a0008d87de1
😎 Deploy Preview https://deploy-preview-3709--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@michaldudak michaldudak merged commit a0f6cf5 into mui:master Jan 9, 2026
23 of 24 checks passed
@oliviertassinari oliviertassinari deleted the bundle-size-select branch January 9, 2026 14:22
@oliviertassinari

oliviertassinari commented Jan 11, 2026

Copy link
Copy Markdown
Member Author

Actually, this PR/type of opportunity, combined with #3688 makes me think of

I could definitely see a working program where we reward $ for every byte minified and gzipped that people manage to save without harming the readability or features. Is there 10,000 bytes that can be saved? Probably. Is there 15,000? That would be harder. 20,000? That sounds really hard, but impactful. I would love to see AI improve enough to the point where it can make it happen.

@cristianbote's https://goober.rocks/the-great-shave-off set a cool precedent for this. One limit: it seems hard to get people to move the needle: https://opencollective.com/goober/expenses had like 2-3 rewards distributed. But at least it can serve as proof of our commitment, we care.

So we should increase the minified gzipped byte saved -> $ ratio. We can try x1.5. Saving 15,000 bytes would mean distributing $20,000. As for changes that lead to large payouts, I have proposed in the Notion page ⬆️ a way to stay fair for the smaller, harder improvements. This should encourage keeping PRs scopped too, easier to review, revert.

cc @mnajdova for awareness.

@oliviertassinari

oliviertassinari commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

Ok, let's try an experimental pilot version of this, we copy the name "The great shave off" 😁. Notion page updated. This way we will learn if it works, and we can fix what doesn't make much sense.

We got our first bounty with #3805 from @sai6855 -24B gzipped -> $36.

@cristianbote

Copy link
Copy Markdown

@oliviertassinari this is fantastic! 😄 Is there an announcement or a page where the challenge is presented? I wanna share it around in my network as well and drive more attention.

@oliviertassinari

oliviertassinari commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

@cristianbote We have no public announcement at this stage. The only page is the public Notion page above. I think we should be in an experimental phase. I think we should first try to figure out if the operational aspect of it works:

  • Fairness: Is the reward function well-sized?
  • Priorities: Are we distracting the product roadmaps with too many contributor PRs?
  • Operations: Are we able to effectively do the payout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. performance type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants