[mergeProps] Make mergeProps public#3642
Merged
Merged
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaldudak
force-pushed
the
document-merge-props
branch
from
02ece77 to
d49021f
Compare
LukasTy
approved these changes
Dec 30, 2025
LukasTy
left a comment
LukasTy
left a comment
Member
There was a problem hiding this comment.
LGTM. 👍
Thanks for addressing this. 🙏
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
dav-is
reviewed
Dec 30, 2025
| ...props | ||
| }: ParametersReferenceTableProps) { | ||
| return ( | ||
| <PropsReferenceAccordion |
Member
There was a problem hiding this comment.
Would it make sense to abstract this into a <ReferenceAccordion/> component which both the parameters and props table would use?
atomiks
reviewed
Dec 31, 2025
Comment on lines
+30
to
+33
| - For React synthetic events, Base UI adds `event.preventBaseUIHandler()`. Calling it sets `event.baseUIHandlerPrevented = true`. | ||
| This does not call `preventDefault()` or `stopPropagation()`. | ||
| It only tells Base UI to skip earlier merged handlers or internal logic that checks the flag. | ||
| - For non-synthetic events (custom events with primitive/object values), this mechanism isn't available and all handlers always execute. |
Contributor
There was a problem hiding this comment.
There's extra indentation here
atomiks
reviewed
Dec 31, 2025
Comment on lines
+26
to
+28
| ```ts | ||
| mergeProps({ onClick: a }, { onClick: b }); // b runs before a | ||
| ``` |
Contributor
There was a problem hiding this comment.
The code blocks are missing a title, maybe the comments could be moved to the title
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
Member
Author
|
I addressed all the comments. |
flaviendelangle
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mergePropswas already exported from the package, but not documented. As it's useful (shadcn components use it, for example), I added the docs page for it.The docs were generated using an updated infrastructure, so the API definitions are taken from JSDocs (as in components) and not typed by hand.
Docs: https://deploy-preview-3642--base-ui.netlify.app/react/utils/merge-props