Skip to content

Fix [data-filled] behavior in <Select.Root multiple> #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guisehn wants to merge 2 commits into from
Closed

Fix [data-filled] behavior in <Select.Root multiple> #3611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbbf646
add tests
guisehn Dec 24, 2025
433eef0
adjust logic
guisehn Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions packages/react/src/select/root/SelectRoot.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,6 +1488,73 @@ describe('<Select.Root />', () => {

expect(trigger).to.have.attribute('data-filled');
});

describe('on multiple selects', () => {
it('adds [data-filled] attribute when at least one item is selected', async () => {
const { user } = await renderFakeTimers(
<Field.Root>
<Select.Root multiple>
<Select.Trigger data-testid="trigger" />
<Select.Portal>
<Select.Positioner>
<Select.Popup>
<Select.Item value="">Select</Select.Item>
<Select.Item value="1">Option 1</Select.Item>
<Select.Item value="2">Option 2</Select.Item>
<Select.Item value="3">Option 3</Select.Item>
</Select.Popup>
</Select.Positioner>
</Select.Portal>
</Select.Root>
</Field.Root>,
);

const trigger = screen.getByTestId('trigger');
expect(trigger).not.to.have.attribute('data-filled');

await user.click(trigger);

await flushMicrotasks();
clock.tick(200);

const option = screen.getByRole('option', { name: 'Option 1' });

// Arrow Down to focus the Option 1
await user.keyboard('{ArrowDown}');
await user.click(option);
await flushMicrotasks();

expect(trigger).to.have.attribute('data-filled', '');
await flushMicrotasks();

const select = screen.getByRole('listbox');
expect(select).not.to.have.attribute('data-filled');
});

it('adds [data-filled] attribute when already filled', async () => {
await renderFakeTimers(
<Field.Root>
<Select.Root multiple defaultValue={['1']}>
<Select.Trigger data-testid="trigger" />
<Select.Portal>
<Select.Positioner>
<Select.Popup>
<Select.Item value="">Select</Select.Item>
<Select.Item value="1">Option 1</Select.Item>
<Select.Item value="2">Option 2</Select.Item>
<Select.Item value="3">Option 3</Select.Item>
</Select.Popup>
</Select.Positioner>
</Select.Portal>
</Select.Root>
</Field.Root>,
);

const trigger = screen.getByTestId('trigger');

expect(trigger).to.have.attribute('data-filled');
});
});
});

it('[data-focused]', async () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/select/root/SelectRoot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ export function SelectRoot<Value, Multiple extends boolean | undefined = false>(
}, [store, value]);

useIsoLayoutEffect(() => {
setFilled(value !== null);
}, [value, setFilled]);
setFilled(multiple && Array.isArray(value) ? value.length > 0 : value !== null);
}, [value, multiple, setFilled]);

useIsoLayoutEffect(
function syncSelectedIndex() {
Expand Down
Loading