[select] Fix filled state in multiple mode#3608
Merged
Merged
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mnajdova
reviewed
Dec 24, 2025
| it('does not add [data-filled] attribute when multiple value is empty', async () => { | ||
| const { user } = await renderFakeTimers( | ||
| <Field.Root> | ||
| <Select.Root multiple> |
Member
There was a problem hiding this comment.
Should we add test also when defaultValue={[]}?
mnajdova
approved these changes
Dec 24, 2025
mnajdova
left a comment
mnajdova
left a comment
Member
There was a problem hiding this comment.
Looks good, check one comment about potentially adding one more test.
This was referenced Dec 25, 2025
atomiks
force-pushed
the
fix/select-multiple-filled
branch
from
fa48d50 to
7c976c7
Compare
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Dec 28, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
multiple, the empty state is an empty array, notnull.Fixes #3610