[popups] Fix onOpenChangeComplete(true) timing#3558
Merged
Conversation
atomiks
added
type: bug
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
fix/openchangecomplete-aborted
branch
from
ea5feae to
8a9b61d
Compare
atomiks
changed the title
onOpenChangeCompleteonOpenChangeComplete(true) timing
atomiks
force-pushed
the
fix/openchangecomplete-aborted
branch
from
8a9b61d to
f70ad55
Compare
atomiks
force-pushed
the
fix/openchangecomplete-aborted
branch
from
9a6db31 to
02a2bda
Compare
atomiks
force-pushed
the
fix/openchangecomplete-aborted
branch
from
02a2bda to
56f65b4
Compare
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3555
After the change to remove
ReactDOM.flushSync(...)in #3424,onOpenChangeComplete(true)would sometimes incorrectly fire immediately without waiting for the animation to finish. That's because the double rAF wasn't enough sometimes for[data-starting-style]to have been removed. This changes it to a MutationObserver that will wait for the attr to be removed before callingelement.getAnimations(). Also refactorsuseOpenChangeCompleteto use theAbortController.Original issue: https://stackblitz.com/edit/rtmdhqzj-4tjxwtcd