[menu] Avoid disabling modality on click after hover-open#3455
Merged
Conversation
atomiks
added
component: menu
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
fix/menu-popover-modal
branch
from
aa38e60 to
1984235
Compare
Member
|
Opening on hover doesn't work reliably now with Screen.Recording.2025-12-09.at.10.16.06.mov |
github-actions
Bot
added
the
PR: out-of-date
atomiks
force-pushed
the
fix/menu-popover-modal
branch
from
b2266d4 to
2f726ad
Compare
github-actions
Bot
removed
the
PR: out-of-date
atomiks
changed the title
atomiks
force-pushed
the
fix/menu-popover-modal
branch
2 times, most recently
from
c315ac5 to
905d0c1
Compare
atomiks
changed the title
atomiks
force-pushed
the
fix/menu-popover-modal
branch
from
905d0c1 to
5ceeb4c
Compare
atomiks
force-pushed
the
fix/menu-popover-modal
branch
from
5ceeb4c to
9b667ca
Compare
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Dec 30, 2025
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Dec 30, 2025
1 task
atomiks
added a commit
to atomiks/base-ui
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug when a menu is opened on hover, and is then clicked to "stick": the
modalprop would incorrectly be ignored