[all components] Include ref in BaseUIComponentProps#2813
Merged
Conversation
atomiks
added
type: enhancement
atomiks
commented
Sep 23, 2025
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
atomiks
force-pushed
the
refactor/component-props
branch
from
945f993 to
3dae1ae
Compare
github-actions
Bot
added
the
PR: out-of-date
Signed-off-by: atomiks <cc.glows@gmail.com>
github-actions
Bot
removed
the
PR: out-of-date
michaldudak
reviewed
Dec 16, 2025
| const Trigger = React.forwardRef(function Trigger( | ||
| props: Menu.Trigger.Props, | ||
| ref: React.ForwardedRef<HTMLDivElement>, | ||
| ref: React.ForwardedRef<any>, |
Member
There was a problem hiding this comment.
Why is this needed? Can we use Element instead?
Contributor
Author
There was a problem hiding this comment.
There's an error at ref otherwise; HTMLElement/Element both don't work as it expects HTMLButtonElement.
React 19 works fine though without forwardRef
michaldudak
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes React 17-18 lie, but shouldn't cause type errors.
This prioritises React 19 where
refs are included inpropsto make the types easier.