Conversation
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apache/hadoopatdbcc7cd797100e6b32cd84f85b53a5193a5f9af0with a benchmark-gradecompare-outputsrun and record the result indocs/BENCHMARKS.mddocs/scan-duration-vs-files.svgafter adding the Hadoop timing row (278.63svs4575.96s,16.42×faster)Issues
https://github.com/apache/hadoopatdbcc7cd797100e6b32cd84f85b53a5193a5f9af0Scope and exclusions
.expected.jsonor golden fixture updatesIntentional differences from Python
Apache-2.0 AND LGPL-2.1-onlyover-assertion on plain Apache notice headersFollow-up work
Validation
cargo test test_collapse_repeated_sourcemap_license_detections_combines_concrete_detectionscargo test test_detect_multiline_x_editable_actual_line5_shape_survives_postprocess_boundarycargo test test_detect_multiline_x_editable_actual_line5_shape_end_to_endcargo test test_collect_trailing_orphan_tokens_absorbs_name_before_legal_tailcargo test test_derive_holder_from_simple_copyright_string_strips_and_onwards_prefixcargo test test_extract_comment_author_supplements_handles_html_comment_by_linenpm run check:docscargo run --manifest-path xtask/Cargo.toml --bin compare-outputs -- --repo-url https://github.com/apache/hadoop.git --repo-ref 7b92f0bc7f8fb8f243635493da76e8f59475ef87 --profile commonBenchmark evidence
apache/hadoop @ dbcc7cd797100e6b32cd84f85b53a5193a5f9af0.provenant/compare-runs/20260506T074747Z-hadoop-2810016,370278.63s; ScanCode4575.96s(16.42×faster)Expected-output fixture changes
.expectedfixtures changed; this branch updates runtime behavior and benchmark docs only