fix(copyright): tighten wrapper and notice extraction#847
Merged
Conversation
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PX4/eigen @ 7cf1c0179eb0f5499dfc1bffbd229783a7865fe1withcompare-outputs --profile common, record the reviewed benchmark result indocs/BENCHMARKS.md, and refreshdocs/scan-duration-vs-files.svg.PRODUCT_COPYRIGHT,applicationLegalese,LegalCopyright, and storyboardtext=wrappers from emitted copyrights.Issues
Scope and exclusions
.provenant/compare-runs/20260504T211702Z-eigen-62479/,.provenant/compare-runs/20260505T102504Z-flutter-12526/, and.provenant/compare-runs/20260505T104455Z-eigen-34962/src/copyright/refiner/tests.rs,src/copyright/detector/tests.rs, andsrc/scanner/process/copyright_test.rsxtask/src/bin/compare_outputs.rscorrect-copyright-minpackgolden update<emaillines remain source-faithful for nowIntentional differences from Python
All rights reserved.when it is part of the source notice, while keeping the normalized shadow/refined comparison semantics separate.Follow-up work
sky_engine/LICENSEDesire NUENTSA WAKAM)Copyright (c) Microsoft Corporationvs bare(c) Microsoft Corporationthat are lower-priority than the false-positive and wrapper-shell fixes completed hereExpected-output fixture changes
testdata/copyright-golden/copyrights/misco3/correct-copyright-minpack.txt.ymlCopyright Notice (1999) University of Chicagoform and matching holder directly from the copied fixture text, and the focused regression tests cover that behavior.