Skip to content

refactor(app): share scan pipeline between cli and workflow#835

Merged
mstykow merged 7 commits intomainfrom
refactor/internal-scan-pipeline
May 3, 2026
Merged

refactor(app): share scan pipeline between cli and workflow#835
mstykow merged 7 commits intomainfrom
refactor/internal-scan-pipeline

Conversation

@mstykow
Copy link
Copy Markdown
Owner

@mstykow mstykow commented May 2, 2026

Summary

  • add a shared internal app-layer scan pipeline so the CLI and library workflow facade execute through the same request, planning, runtime, and output path
  • add a public workflow embedding facade plus a concise docs/LIBRARY_GUIDE.md for supported Rust library usage today
  • fix multi-input absolute path handling, add workflow doctests, and restore doctest verification in CI

Issues

Scope and exclusions

  • Included:
    • shared internal scan orchestration for CLI and library entry points
    • public workflow::{scan_path, scan_paths} embedding surface
    • library guide and README/docs index discoverability updates
    • absolute multi-input path fix for shared native scan selection
    • workflow doctests and CI doctest verification
  • Explicit exclusions:

Intentional differences from Python

  • expose a first-class Rust workflow facade while still reusing the same ScanCode-compatible internal output pipeline used by the CLI

Follow-up work

  • Created or intentionally deferred:
    • Create provenant serve API #834 remains open for future serve/API design and broader library-surface follow-up
    • CLI guide wording and a dedicated CLI regression around absolute multi-input scans can follow separately if we want stronger user-facing coverage there

Expected-output fixture changes

  • Files changed: none
  • Why the new expected output is correct: no golden or expected-output fixtures changed; behavior changes were validated with unit tests, doctests, clippy, final review passes, and CLI smoke coverage

mstykow and others added 7 commits May 2, 2026 21:44
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
@mstykow mstykow merged commit 3ebdce4 into main May 3, 2026
15 checks passed
@mstykow mstykow deleted the refactor/internal-scan-pipeline branch May 3, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant