fix(gradle): resolve buildSrc dependency constants and verify fresco#824
Merged
fix(gradle): resolve buildSrc dependency constants and verify fresco#824
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildSrcconstants when Gradle manifests use symbolic refs such asDeps.AndroidX.*,Deps.Bolts.*,GradleDeps.*, andTestDeps.*, then keep the resulting dependency attached to the referencingbuild.gradleinstead of duplicating it onto the supporting.ktfilesfacebook/fresco @ c991a692a254358d1cf56c5b4b06e6c5dd96cfabwithcompare-outputs --profile common, record the final checkpoint indocs/BENCHMARKS.md, and regeneratedocs/benchmarks/scan-duration-vs-files.svgbuildsrc-constantsfixture tree that exercises nested Kotlinobjectconstants plus simple$versioninterpolationScope and exclusions
buildSrcKotlin constants underbuildSrc/src/main/javaandbuildSrc/src/main/kotlinobject/const valreferences and simple$name/${name}interpolation when they collapse to literalgroup:name:versioncoordinatesbuildSrccode evaluationIntentional differences from Python
buildSrcconstant references to exact Maven coordinates when the supporting Kotlin files are committed nearby. In the Fresco case,imagepipeline-base/build.gradlecan therefore surface concrete dependencies likeandroidx.exifinterface:exifinterface:1.3.7andcom.parse.bolts:bolts-tasks:1.4.0instead of leaving the reference unresolved.buildSrcconstant exists, Provenant intentionally prefers an honest unknown over placeholder package identities. We do not emit a dependency entry for unresolved refs such asDeps.AndroidX.androidxAnnotation; we also do not fall back to ScanCode-style placeholders likepkg:maven/AndroidX.datafile_path: "imagepipeline-base/build.gradle"plusextra_data.symbolic_ref, while the supportingbuildSrc/*.ktfiles remain ordinary scanned source files withpackage_data: [].Follow-up work
.provenant/compare-runs/20260429T191522Z-fresco-70123/.provenant/compare-runs/20260429T193659Z-fresco-98279/cargo test buildsrc_kotlin_constantscargo test parsers::gradle::tests::cargo test gradle_scan_test::tests::cargo test --features golden-tests test_golden_groovy_buildsrc_constantsExpected-output fixture changes
testdata/gradle-golden/groovy/buildsrc-constants/build.gradle-expected.jsonbuildsrc-constantsfixture inputs and the golden registration insrc/parsers/gradle_golden_test.rsbuildSrcKotlin constants that live at the repo root in the fixture tree, so the parser can resolve them statically without executing Gradlebuild.gradlewithsymbolic_refmetadata, while the supporting.ktfiles themselves continue to produce no package databuildSrcmatch exists