Skip to content

fix(copyright): filter trade-secret notice false positives#810

Merged
mstykow merged 2 commits intomainfrom
fix/copyright-trade-secret-notice
Apr 28, 2026
Merged

fix(copyright): filter trade-secret notice false positives#810
mstykow merged 2 commits intomainfrom
fix/copyright-trade-secret-notice

Conversation

@mstykow
Copy link
Copy Markdown
Owner

@mstykow mstykow commented Apr 28, 2026

Summary

  • add a refiner junk-pattern rule for extracted copyright and trade secret[s] boilerplate fragments
  • add targeted copyright regressions for the refiner and detector pipeline, using an anonymized Acme Inc. notice sample
  • preserve the real copyright/holder extraction while preventing the confidentiality-notice false positive

Scope and exclusions

  • Included:
    • refiner-layer junk filtering for trade-secret boilerplate fragments
    • unit and detector-level regression coverage for the reported false positive
  • Explicit exclusions:
    • broader detector/tree-walk refactors toward ScanCode's parser/token architecture
    • golden fixture changes or output-schema changes

Intentional differences from Python

  • none intended; this change narrows Provenant's behavior toward ScanCode by dropping a false-positive boilerplate fragment that ScanCode does not emit

Follow-up work

  • Created or intentionally deferred:
    • evaluate whether a small amount of earlier candidate/token filtering would reduce future late-stage junk-pattern additions without adopting ScanCode's architecture wholesale

mstykow added 2 commits April 28, 2026 21:43
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
@mstykow mstykow enabled auto-merge (rebase) April 28, 2026 19:53
@mstykow mstykow merged commit c850088 into main Apr 28, 2026
15 checks passed
@mstykow mstykow deleted the fix/copyright-trade-secret-notice branch April 28, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant