Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/msgpack.erl
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,15 @@ unpack_stream(Bin) -> unpack_stream(Bin, []).
unpack_stream(Bin, Opts0) when is_binary(Bin) ->
Opts = parse_options(Opts0),
try
msgpack_unpacker:unpack_stream(Bin, Opts)
Opts1=Opts?OPTION{
known_atoms=lists:map(
fun(X) ->
erlang:atom_to_binary(X, utf8)
end,
Opts?OPTION.known_atoms
)
},
msgpack_unpacker:unpack_stream(Bin, Opts1)
catch
throw:Exception -> {error, Exception}
end;
Expand Down
2 changes: 1 addition & 1 deletion src/msgpack.hrl
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
-record(options_v4, {
spec = new :: new | old,
allow_atom = pack :: none | pack, %% allows atom when packing
known_atoms = [] :: [atom()],
known_atoms = [] :: [atom()|binary()],
unpack_str = as_list :: as_binary | as_list | as_tagged_list,
validate_string = false :: boolean(),
pack_str = from_list :: from_binary | from_list | from_tagged_list | none,
Expand Down
8 changes: 8 additions & 0 deletions src/msgpack_unpacker.erl
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,14 @@ unpack_str_or_raw(V, ?OPTION{spec=new,
as_tagged_list -> {string, unpack_str(V)}
end, Rest}.

maybe_bin(Bin, ?OPTION{known_atoms=Known}) when Known=/=[] ->
case lists:member(Bin,Known) of
true ->
erlang:binary_to_existing_atom(Bin,utf8);
false ->
Bin
end;

maybe_bin(Bin, _) ->
Bin.

Expand Down
7 changes: 7 additions & 0 deletions test/msgpack_tests.erl
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,13 @@ binary_test_() ->
end}
].

atom_test_() ->
Map1=#{atom1=>atom1,atom2=><<"binary2">>},
Bin=msgpack:pack(Map1),
?_assertEqual({ok,#{<<"atom1">>=><<"atom1">>,
<<"atom2">>=><<"binary2">>}}, msgpack:unpack(Bin)),
?_assertEqual({ok,Map1}, msgpack:unpack(Bin,[{known_atoms,[atom1,atom2]}])).

-define(PCNT, 5).
-define(CNT, 10000).

Expand Down