✨ Allow select keybinds to ignore the trigger key

[cipher-shad0w]

#260

[cipher-shad0w]

There’s just one problem right now — currently, you can set any single key as a trigger for an action, for example just a single letter. What should I check for? A minimum of 2 keys? And certain keys that must be included so that the custom trigger key can be used?

[mrkai77]

There’s just one problem right now — currently, you can set any single key as a trigger for an action, for example just a single letter. What should I check for? A minimum of 2 keys? And certain keys that must be included so that the custom trigger key can be used?

I'd say a minimum of at least one modifier key and one non-modifier key, and then a maximum of around 5 keys in total (e.g. 4 modifiers, one key).

[cipher-shad0w]

I'd say a minimum of at least one modifier key and one non-modifier key, and then a maximum of around 5 keys in total (e.g. 4 modifiers, one key).

Does Loop has anything implemented to check if sth is a modifier key or not?

[mrkai77]

There is CGKeyCode.isModifier. Additionally, it likely makes sense to map these via CGKeyCode.baseModifier to eliminate the left/right key code distinction.

[mrkai77]

@cipher-shad0w do you have any updates on this?

[cipher-shad0w]

Oh yeah sry, I've implemented everything you ask for and fixed everything you commented

[mrkai77]

I made a few changes that fixed some bugs on my end and also optimized parts of both your code and the existing code. Everything works perfectly now, thank you!