Skip to content

🐞 Force close TriggerKeycorder when window loses focus #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkai77 merged 1 commit into from
Jan 4, 2026
Merged

🐞 Force close TriggerKeycorder when window loses focus #941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Loop/Settings Window/Settings/Keybinds/Keybind Recorder/TriggerKeycorder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ import SwiftUI
struct TriggerKeycorder: View {
@EnvironmentObject private var model: KeybindsConfigurationModel
@Environment(\.luminareAnimation) private var luminareAnimation
@Default(.sideDependentTriggerKey) private var sideDependentTriggerKey
@Environment(\.appearsActive) private var appearsActive

let keyLimit: Int = 5

@Default(.sideDependentTriggerKey) private var sideDependentTriggerKey

@Binding private var validCurrentKey: Set<CGKeyCode>
@State private var selectionKey: Set<CGKeyCode>

Expand Down Expand Up @@ -98,6 +100,11 @@ struct TriggerKeycorder: View {
finishedObservingKeys(wasForced: true)
}
}
.onChange(of: appearsActive) { _ in
if appearsActive {
finishedObservingKeys(wasForced: true)
}
}
.onChange(of: validCurrentKey) { _ in
if selectionKey != validCurrentKey {
selectionKey = validCurrentKey
Expand Down