✨ Lightweight IconView#893
Merged
Merged
Conversation
SenpaiHunters
approved these changes
Nov 18, 2025
SenpaiHunters
left a comment
SenpaiHunters
left a comment
Collaborator
There was a problem hiding this comment.
I've reviewed each file and noticed that sizing changes were made, for example, from 12 to 14. I assume this is in accordance with macOS 26 or for another reason. Visually, I don't see a significant change. Regardless, everything is accepted, and I hope this will resolve some issues we've been experiencing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some time, the SwiftUI-based
IconViewhas occasionally caused issues. The most notable problem was that it could lag one state behind after a user updated a selection in the keybinds tab. Other issues included stuttering animations and high rendering costs, although the latter could potentially have been optimized within SwiftUI itself.By switching to a dedicated
NSViewbacked byCALayersfor rendering icons, we gain more control over when the view updates and benefit from a more lightweight rendering backend. This allows Loop to focus its resources on higher-priority tasks in the settings window.