🐞 Use screen.displayBounds instead of screen.frame#850
Merged
mrkai77 merged 2 commits intoOct 19, 2025
Merged
Conversation
4 tasks
mrkai77
force-pushed
the
835-window-jump-when-dragging-on-the-secondary-external-display
branch
from
61144f7 to
a4056b4
Compare
…ndary-external-display
mrkai77
deleted the
835-window-jump-when-dragging-on-the-secondary-external-display
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loop was previously using the wrong display frame property to determine where to place a restored frame for a window. While the previous method worked mostly fine on single-display setups, this method did not work well on multi-display setups. This is because
NSScreen.frame(which we were previously using) provides the screen frame in AppKit coordinate space, whose origin is not the same as what the accessibility API uses (CoreGraphics coordinate space). UsingNSScreen.displayBoundswill fix this.