Skip to content

🐞 Convert rects to integers before applying padding#715

Merged
mrkai77 merged 9 commits into
developfrom
bottom-padding-fix
Apr 14, 2025
Merged

🐞 Convert rects to integers before applying padding#715
mrkai77 merged 9 commits into
developfrom
bottom-padding-fix

Conversation

@mrkai77

@mrkai77 mrkai77 commented Apr 5, 2025

Copy link
Copy Markdown
Owner

No description provided.

@mrkai77 mrkai77 added the Bug label Apr 5, 2025
@mrkai77 mrkai77 requested a review from Copilot April 5, 2025 03:28
@mrkai77 mrkai77 self-assigned this Apr 5, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

Loop/Window Management/WindowAction.swift:154

  • [nitpick] The variable 'bounds' is re-declared, shadowing the parameter 'bounds'. Consider renaming it to 'paddedBounds' to improve clarity.
var bounds: CGRect = getBounds(from: bounds, disablePadding: disablePadding, screen: screen)

@mrkai77 mrkai77 marked this pull request as ready for review April 14, 2025 02:49
@mrkai77 mrkai77 merged commit 856fb70 into develop Apr 14, 2025
@mrkai77 mrkai77 deleted the bottom-padding-fix branch April 14, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants