🐞 Fix memory leak inside CGEventMonitor#694
Merged
mrkai77 merged 1 commit intoMar 6, 2025
Merged
Conversation
- Pass user info as unretained into the `callback` to avoid the mach port never being released. - Invalidate the event tap inside `deinit`.
4 tasks
SenpaiHunters
approved these changes
Mar 1, 2025
mrkai77
approved these changes
Mar 6, 2025
mrkai77
left a comment
mrkai77
left a comment
Owner
There was a problem hiding this comment.
I think it makes sense to now merge this, as it seems to fix the issue based on the latest info from other commenters. Will release a new dev version containing this fix so that a larger audience can participate in testing!
mrkai77
changed the title
CGEventMonitorCGEventMonitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help fix the issue where things slow down after a period of usage as it no longer keeps previous event monitors around after looping as it resigned its usage via
LoopManager.closeLoop.Before, event monitor was passed as retained to itself, which quickly created a retain cycle. Also, I added proper cleanup by invalidating the mach port when the event monitor is about to go out of scope.
callbackto avoid the mach port never being released.deinit.