Skip to content

🐞 Move window activation to after minimizing/hiding #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkai77 merged 1 commit into from
Jan 22, 2025
Merged

🐞 Move window activation to after minimizing/hiding #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Loop/Window Management/WindowEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@ enum WindowEngine {
let windowTitle = window.nsRunningApplication?.localizedName ?? window.title ?? "<unknown>"
print("Resizing \(windowTitle) to \(action.direction) on \(screen.localizedName)")

// Note that this is only really useful when "Resize window under cursor" is enabled
if Defaults[.focusWindowOnResize] {
window.activate()
}

// If the action is to hide or minimize, perform the action then return
if action.direction == .hide {
window.toggleHidden()
Expand All @@ -43,6 +38,11 @@ enum WindowEngine {
return
}

// Note that this is only really useful when "Resize window under cursor" is enabled
if Defaults[.focusWindowOnResize] {
window.activate()
}

if shouldRecord {
WindowRecords.record(window, action)
}
Expand Down