Skip to content

🐞 Fix references to non-existent images, remove beep sound #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SenpaiHunters merged 1 commit into from
Sep 27, 2024
Merged

🐞 Fix references to non-existent images, remove beep sound #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Loop/Assets.xcassets/Window Actions/Contents.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions ...ets/Window Actions/custom.macwindow.trianglebadge.exclamationmark.symbolset/Contents.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...ge.exclamationmark.symbolset/custom.macwindow.trianglebadge.exclamationmark.svg
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions Loop/Assets.xcassets/Window Actions/custom.rectangle.slash.symbolset/Contents.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...sets/Window Actions/custom.rectangle.slash.symbolset/custom.rectangle.slash.svg
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion Loop/Luminare/LuminareManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import SwiftUI
class LuminareManager {
static let iconConfiguration = SettingsTab("Icon", Image(._18PxSquareSparkle), IconConfigurationView())
static let accentColorConfiguration = SettingsTab("Accent Color", Image(._18PxPaintbrush), AccentColorConfigurationView())
static let radialMenuConfiguration = SettingsTab("Radial Menu", Image("loop"), RadialMenuConfigurationView())
static let radialMenuConfiguration = SettingsTab("Radial Menu", Image(.loop), RadialMenuConfigurationView())
static let previewConfiguration = SettingsTab("Preview", Image(._18PxSidebarRight2), PreviewConfigurationView())

static let behaviorConfiguration = SettingsTab("Behavior", Image(._18PxGear), BehaviorConfigurationView())
Expand Down
4 changes: 0 additions & 4 deletions Loop/Managers/LoopManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,6 @@ private extension LoopManager {
// Icon stuff
Defaults[.timesLooped] += 1
IconManager.checkIfUnlockedNewIcon()
} else {
if targetWindow == nil, isLoopActive {
NSSound.beep()
}
}

isLoopActive = false
Expand Down
2 changes: 1 addition & 1 deletion Loop/Radial Menu/RadialMenuView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ struct RadialMenuView: View {

Group {
if window == nil, previewMode == false {
Image("custom.macwindow.trianglebadge.exclamationmark")
Image(systemName: "exclamationmark.triangle")
} else if let image = currentAction.radialMenuImage {
image
}
Expand Down
4 changes: 2 additions & 2 deletions Loop/Window Management/WindowAction+Image.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ extension WindowAction {
var radialMenuImage: Image? {
switch direction {
case .hide:
Image("custom.rectangle.slash")
Image(systemName: "eye.slash")
case .minimize:
Image("custom.arrow.down.right.and.arrow.up.left.rectangle")
Image(systemName: "arrow.down.right.and.arrow.up.left")
default:
nil
}
Expand Down