Skip to content

Add missing icons for stash/unstash directions #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
william-laverty wants to merge 4 commits into from
Closed

Add missing icons for stash/unstash directions #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
092e676
Add missing icons for stash/unstash directions (#1036)
william-laverty Feb 4, 2026
820782d
fix: move stash icon to fallback in IconView per reviewer feedback
william-laverty Feb 6, 2026
99d9a38
fix: add stash icon as fallback when no calculated frame available
william-laverty Feb 6, 2026
37fc712
Merge branch 'develop' into fix/missing-stash-icons
william-laverty Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Loop/Window Management/Window Action/IconView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ final class IconRenderView: NSView {
return .frame(fillFrame)
}

// And if all else fails...
// Fallback icons for actions that can't display calculated frames

if currentAction.direction == .custom, let image = NSImage(systemSymbolName: "slider.horizontal.3", accessibilityDescription: nil) {
return .image(image)
Expand All @@ -210,6 +210,11 @@ final class IconRenderView: NSView {
return .image(image)
}

// Stash icon as fallback when no anchor is selected (can't calculate frame)
if currentAction.direction == .stash, let image = NSImage(systemSymbolName: "square.stack.3d.down.right", accessibilityDescription: nil) {
return .image(image)
}

return nil
}

Expand Down
4 changes: 4 additions & 0 deletions Loop/Window Management/Window Action/WindowAction+Image.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ extension WindowAction {
switch direction {
case .noAction:
.systemImage("questionmark")
case .noSelection:
nil // No selection state should not display an icon
case .undo:
.systemImage("arrow.uturn.backward")
case .initialFrame:
Expand Down Expand Up @@ -93,6 +95,8 @@ extension WindowAction {
.systemImage("chevron.down")
case .focusNextInStack:
.systemImage("rectangle.stack")
case .unstash:
.systemImage("square.stack.3d.up")
default:
nil
}
Expand Down