Fix 500 on default aaq topic selection#7289
Open
emilghittasv wants to merge 1 commit into
Open
Conversation
akatsoulas
reviewed
Mar 5, 2026
| ): | ||
| topic_id = request.GET.get("category") | ||
| if not topic_id: | ||
| return HttpResponse(status=204) |
Collaborator
There was a problem hiding this comment.
We are getting a validation error that instead of the topic id which we need to retrieve it form the db (and it's an integer) we are getting an empty string. The proposed response will silence the error but it's not fixing the underlying problem
Contributor
There was a problem hiding this comment.
Hey @akatsoulas, could you please elaborate on what underlying problem you meant above? Did you mean that we need to validate that topic_id is an integer here, or that we shouldn't send a hx-request at all when the category is empty?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.