fix: make ClientSessionGroup streamable HTTP errors catchable#2637
Open
VrtxOmega wants to merge 1 commit into
Open
fix: make ClientSessionGroup streamable HTTP errors catchable#2637VrtxOmega wants to merge 1 commit into
VrtxOmega wants to merge 1 commit into
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean replacement for #2522.
The previous PR became unreviewable after the branch was repushed against an old base, causing a large unrelated diff. This PR is based on current main and contains only the relevant #915 changes.
Summary
ClientSessionGroupsession exit stacks sequentially so AnyIO cancel scopes are exited in the task that entered them.RuntimeErrorfrom Exception inClientSessionGroupifstreamable_httpMCP server is not available #915.Validation
uv run ruff format --check src/mcp/client/session_group.py tests/client/test_session_group.pyuv run ruff check src/mcp/client/session_group.py tests/client/test_session_group.pyuv run pyright src/mcp/client/session_group.py tests/client/test_session_group.pyuv run pytest tests/client/test_session_group.py -q