Fix extractRegion() matching region names that are substrings of others#376
Merged
jonathanhefner merged 1 commit intomodelcontextprotocol:mainfrom Jan 27, 2026
Conversation
The `extractRegion()` function in `sync-snippets.ts` used `indexOf()` to find region markers like `//#region persistData`. This caused incorrect matching when one region name was a prefix of another—searching for `persistData` would match `//#region persistDataServer` first if it appeared earlier in the file. The fix detects the file's line ending style and appends it to region markers, ensuring exact matches: - `//#region persistData\n` no longer matches `//#region persistDataServer\n` This corrects `docs/patterns.md` where the `persistData` code fence was incorrectly showing server-side code instead of client-side localStorage helpers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-map
@modelcontextprotocol/server-pdf
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-shadertoy
@modelcontextprotocol/server-sheet-music
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-transcript
@modelcontextprotocol/server-video-resource
@modelcontextprotocol/server-wiki-explorer
commit: |
jonathanhefner
merged commit 6c8379f
into
modelcontextprotocol:main
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
extractRegion()function insync-snippets.tsusedindexOf()to find region markers like//#region persistData. This caused incorrect matching when one region name was a prefix of another—searching forpersistDatawould match//#region persistDataServerfirst if it appeared earlier in the file.The fix detects the file's line ending style and appends it to region markers, ensuring exact matches:
//#region persistData\nno longer matches//#region persistDataServer\nThis corrects
docs/patterns.mdwhere thepersistDatacode fence was incorrectly showing server-side code instead of client-side localStorage helpers.