Skip to content

Remove s_additionalProperties from McpClientTool #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Dec 10, 2025
Merged

Remove s_additionalProperties from McpClientTool #1080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4e582
Initial plan
Copilot Dec 9, 2025
d323db6
Remove s_additionalProperties and AdditionalProperties override from …
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/ModelContextProtocol.Core/Client/McpClientTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using Microsoft.Extensions.AI;
using ModelContextProtocol.Protocol;
using System.Collections.ObjectModel;
using System.Text.Json;
using System.Text.Json.Nodes;

Expand All @@ -26,13 +25,6 @@ namespace ModelContextProtocol.Client;
/// </remarks>
public sealed class McpClientTool : AIFunction
{
/// <summary>Additional properties exposed from tools.</summary>
private static readonly ReadOnlyDictionary<string, object?> s_additionalProperties =
new(new Dictionary<string, object?>()
{
["Strict"] = false, // some MCP schemas may not meet "strict" requirements
});

private readonly McpClient _client;
private readonly string _name;
private readonly string _description;
Expand Down Expand Up @@ -126,9 +118,6 @@ internal McpClientTool(
/// <inheritdoc/>
public override JsonSerializerOptions JsonSerializerOptions { get; }

/// <inheritdoc/>
public override IReadOnlyDictionary<string, object?> AdditionalProperties => s_additionalProperties;

/// <inheritdoc/>
protected async override ValueTask<object?> InvokeCoreAsync(
AIFunctionArguments arguments, CancellationToken cancellationToken)
Expand Down