Fixes issues 951 (backported from the main branch) and 954#956
Merged
michelebastione merged 1 commit intoMay 11, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the template value extraction process by ensuring that indexer properties are ignored, which previously caused issues when processing objects. It also updates test assertions for better clarity and adds a regression test for Issue 951. Regarding the code changes, the reviewer pointed out that changing the default excelType to XLSX in MergeSameCellsAsync is inconsistent with the rest of the API and breaks automatic file format detection, suggesting it should remain as UNKNOWN.
michelebastione
merged commit f0d1944
into
mini-software:v1.x-maintenance
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #954