Tolerate missing packages in DLL framework verification#15735
Merged
nohwnd merged 1 commit intomicrosoft:mainfrom May 4, 2026
Merged
Tolerate missing packages in DLL framework verification#15735nohwnd merged 1 commit intomicrosoft:mainfrom
nohwnd merged 1 commit intomicrosoft:mainfrom
Conversation
In VMR/source-build not all packages are built. Skip expected packages that are absent instead of erroring, and only flag new native DLLs not already in the exclude list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DLL target framework verification script to better accommodate VMR/source-build scenarios where not all expected packages are produced, by avoiding failures when expected packages are missing and by relaxing native DLL exclude-list drift detection.
Changes:
- Treat “expected package missing from actual packages” as a warning instead of a mismatch/error.
- Change native exclude-list verification to only flag newly observed native DLLs that aren’t already excluded (ignoring “missing” natives).
- Adjust the auto-update path to always write sorted actual native excludes.
JanKrivanek
approved these changes
May 4, 2026
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In VMR/source-build not all packages are built. Skip expected packages that are absent instead of erroring, and only flag new native DLLs not already in the exclude list.