Add missing handling for OperationCanceledException in DebuggableWrapper#354
Merged
AArnott merged 1 commit intomicrosoft:v15.8from Aug 24, 2018
Merged
Conversation
Member
|
Doh! I guess I missed this method in #234 when I "fixed" this already. I wondered why I was seeing these in the error list even for builds that had my "fix". |
Without this, analyzers observing cancellation end up re-wrapping the exception and showing errors in Visual Studio.
jasonmalinowski
force-pushed
the
fix-cancellation-bug
branch
from
40886e7 to
0612234
Compare
Member
Author
|
@AArnott Done! |
Member
|
Thanks! |
AArnott
approved these changes
Aug 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, analyzers observing cancellation end up re-wrapping the exception and showing errors in Visual Studio.