Skip to content

Remove unused @rushstack/rush-sdk dependency from webpack5/rspack everything-test build-tests#5706

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/clean-up-rush-sdk-dependency
Draft

Remove unused @rushstack/rush-sdk dependency from webpack5/rspack everything-test build-tests#5706
Copilot wants to merge 4 commits intomainfrom
copilot/clean-up-rush-sdk-dependency

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

  • Remove @rushstack/rush-sdk from heft-webpack5-everything-test/package.json
  • Remove @rushstack/rush-sdk from heft-rspack-everything-test/package.json
  • Run rush update to update the lockfile
  • Fix spurious lockfile snapshot: eslint@8.57.1 peer dependency must resolve to eslint@8.57.1, not eslint@9.37.0

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI and others added 2 commits March 17, 2026 00:33
…thing-test and heft-rspack-everything-test

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
@dmichon-msft
Copy link
Copy Markdown
Contributor

@copilot You need to run rush update after making this change.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 20, 2026

@copilot You need to run rush update after making this change.

Done — ran rush update --subspace default which removed the @rushstack/rush-sdk entries from common/config/subspaces/default/pnpm-lock.yaml for both projects. Committed in 3bc8b9f.

eslint@8.57.1:
dependencies:
'@eslint-community/eslint-utils': 4.9.1(eslint@8.57.1)
'@eslint-community/eslint-utils': 4.9.1(eslint@9.37.0)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This can't possibly be right. The consuming package is eslint@8.57.1, the peer therefore must resolve to esling@8.57.1.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 11a698a — reverted the snapshot back to 4.9.1(eslint@8.57.1). This was a spurious change introduced by rush update.

…nt@8.57.1

Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/4c5c525a-b587-4a90-8705-599905da6580

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs triage

Development

Successfully merging this pull request may close these issues.

2 participants