PciHostBridgeLib: Set ResourceAssigned when bus enumeration is disabled#81
Merged
Conversation
When PcdPciDisableBusEnumeration is TRUE, PciBusDxe uses PciEnumeratorLight which requires pre-assigned resources. With ResourceAssigned hardcoded to FALSE, CreateRootBridge sets ResAllocNode[TypeBus].Status to ResNone, so PciRootBridgeIo Configuration never emits the bus descriptor. PciGetBusRange returns EFI_NOT_FOUND and no PCIe devices are discovered. Set ResourceAssigned = PcdGetBool(PcdPciDisableBusEnumeration) so that when bus enumeration is disabled, all valid apertures are marked ResAllocated and Configuration emits them correctly.
chris-oo
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed a fix in #78--we need to set ResourceAssigned to TRUE so that the bridge is successfully enumerated. Without this, you cannot boot from PCIe when the VMM pre-assigns resources.