release: binskim for Windows#924
Draft
mjcheetham wants to merge 1 commit into
Draft
Conversation
The 1ES PT Windows build job did not run binskim against the binaries we ship. By default the template would point binskim at the published artifact (the Inno Setup installer and the 7z self-extracting portable .exe), neither of which binskim can crack open to find the PE files inside, so any findings on those wrappers are also unactionable: they are produced by external tools we do not control. Opt the job into binskim explicitly and aim it at the actual product binaries instead. We extract the portable .exe (a 7z SFX whose payload is the portable Git tree) into a scratch directory alongside the staged release artifacts and scope the analyzer to the .dll/.exe files in there, so binskim inspects exactly the Windows binaries we just built and signed without drowning the run in non-PE noise. Only filter to the core Git binaries (not 3rd party ones like Perl, MSYS2 runtime, GCM, Git LFS etc) since these are what are scoped to this repository. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1ES PT Windows build job did not run binskim against the binaries we ship. By default the template would point binskim at the published artifact (the Inno Setup installer and the 7z self-extracting portable .exe), neither of which binskim can crack open to find the PE files inside, so any findings on those wrappers are also unactionable: they are produced by external tools we do not control.
Opt the job into binskim explicitly and aim it at the actual product binaries instead. We extract the portable .exe (a 7z SFX whose payload is the portable Git tree) into a scratch directory alongside the staged release artifacts and scope the analyzer to the .dll/.exe files in there, so binskim inspects exactly the Windows binaries we just built and signed without drowning the run in non-PE noise.
Only filter to the core Git binaries (not 3rd party ones like Perl, MSYS2 runtime, GCM, Git LFS etc) since these are what are scoped to this repository.
--
Note to reviewers: we will add the suppression for issues we cannot fix (clang/gcc options not possible to use - we don't use msvc!) shortly.