Skip to content

Separate scrolling from clicking#603

Merged
lhecker merged 1 commit into
mainfrom
dev/lhecker/410-scroll-mouse
Aug 12, 2025
Merged

Separate scrolling from clicking#603
lhecker merged 1 commit into
mainfrom
dev/lhecker/410-scroll-mouse

Conversation

@lhecker

@lhecker lhecker commented Aug 12, 2025

Copy link
Copy Markdown
Member

Closes #410
Closes #588

@lhecker lhecker merged commit 1b7298c into main Aug 12, 2025
3 checks passed
@lhecker lhecker deleted the dev/lhecker/410-scroll-mouse branch August 12, 2025 21:22
@MarkusBillharz

MarkusBillharz commented Aug 13, 2025

Copy link
Copy Markdown

@lhecker

#588 (comment)

But also noticed that it was still not possible to start a selection by:
Left->Scroll while holding the mouse still.

It seems this edge case slipped through here. Currently, the selection starts from where the mouse is first moved, rather than where the button-down was initiated.

Edit: In case it is of interest, I rebased my branch just to fix it locally, still seems sound to me.

I still feel like it might be of some value in terms of reasoning,
but since I’m not sure what you disliked about the initial PR, I’ve held off on creating a new one.

Cheers~

@lhecker

lhecker commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

I don't doubt that your diff solves the issue but I'm trying to fit it into a long term solution where scrolling isn't the same as clicking in the first place. Dragging should also not be a boolean member like that, but rather the UI system should have distinct mouse-down/up events. Basically, I'm looking for a holistic solution rather than an immediate fix.

@lhecker

lhecker commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

I've filed #608 to track this.

Lou32Verbose pushed a commit to Lou32Verbose/edit that referenced this pull request Jan 11, 2026
@lhecker lhecker mentioned this pull request Apr 23, 2026
lhecker added a commit that referenced this pull request Apr 23, 2026
Without a node-path check, the order of UI element creation
mattered. Since models are created after the text area this
meant that the text area would steal all scroll input.

This regressed in #603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selection resets on mouse scroll

3 participants