Fix UTF-8 buffer prepending in read_stdin#520
Merged
Conversation
lhecker
approved these changes
Jun 25, 2025
lhecker
left a comment
lhecker
left a comment
Member
There was a problem hiding this comment.
ARGH! Thank you for noticing this!
Contributor
Author
|
Of course! Thank you for the quick resolution! |
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code zeroed STATE.utf8_len before using it as
a slice index, which causes leftover UTF-8 bytes from
previous reads to be discarded instead of prepended to the buffer