Allow find and replace with an empty string#442
Closed
Shivix wants to merge 1 commit into
Closed
Conversation
Since write specifically checks if string is empty, we could consider allowing an empty write, which does work in testing, but we can instead utilise extract_selection here instead. This is a bit more explicit ensures this change only affects find and replace.
lhecker
requested changes
Jun 10, 2025
lhecker
left a comment
Member
There was a problem hiding this comment.
I don't think this is the right approach. There's no inherent reason why write has to exit early for empty inputs. It's still meaningful if there's an active selection after all.
I've written an alternative approach over in #457 and I'd be happy if you could check it out.
Contributor
Author
|
Yeah fair enough, allowing write to work with an empty input was actually what I went with at first. I had spent some time testing that also and it works well. I just went with the change that has lower potential impact to make it easier to review. |
Member
|
#457 was just merged, so I'll close this PR for now. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the replace field is empty, the write function will do nothing, and hitting enter will simply go through the occurrences replacing nothing.
Allowing the replace string to be empty, allows the user to use find and replace to rapidly erase text.
Since write specifically checks if string is empty, we could consider allowing an empty write, which does work in testing, but we can instead utilise extract_selection here instead. This is a bit more explicit and ensures this change only affects find and replace.
Closes #439