Skip to content

Use blocking reads for setup_terminal #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DHowett merged 2 commits into from
Jun 5, 2025
Merged

Use blocking reads for setup_terminal #424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9593e52
Use blocking reads for setup_terminal
lhecker Jun 4, 2025
d3b4320
Set the read timeout to 3s
lhecker Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/bin/edit/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ use std::borrow::Cow;
#[cfg(feature = "debug-latency")]
use std::fmt::Write;
use std::path::{Path, PathBuf};
use std::time::Duration;
use std::{env, process};

use draw_editor::*;
Expand Down Expand Up @@ -537,7 +538,11 @@ fn setup_terminal(tui: &mut Tui, state: &mut State, vt_parser: &mut vt::Parser)

while !done {
let scratch = scratch_arena(None);
let Some(input) = sys::read_stdin(&scratch, vt_parser.read_timeout()) else {

// We explicitly set a high read timeout, because we're not
// waiting for user keyboard input. If we encounter a lone ESC,
// it's unlikely to be from a ESC keypress, but rather from a VT sequence.
let Some(input) = sys::read_stdin(&scratch, Duration::from_secs(3)) else {
break;
};

Expand Down