Handle ESC/SS3 followed by Unicode characters#244
Merged
Conversation
lhecker
commented
May 23, 2025
| let mut input_mouse_click = 0; | ||
| let mut input_scroll_delta = Point { x: 0, y: 0 }; | ||
| let input_consumed = self.needs_settling(); | ||
| let input_consumed = input.is_none(); |
Member
Author
There was a problem hiding this comment.
An extra fix I smuggled in, as described in the comment. Found during testing by manually injecting a lone Escape followed by another character within the same input payload.
| reason = "can't implement Iterator because this is a lending iterator" | ||
| )] | ||
| pub fn next(&mut self) -> Option<Token<'_, 'input>> { | ||
| let parser = &mut *self.parser; |
Member
Author
There was a problem hiding this comment.
Had to remove it due to borrow issues.
DHowett
approved these changes
May 27, 2025
| // `self.needs_settling() == true`. However, there's a possibility for it being true from | ||
| // a previous frame, and we do have fresh new input. In that case want `input_consumed` | ||
| // to be false of course which is ensured by checking for `input.is_none()`. | ||
| let input_consumed = self.needs_settling() && input.is_none(); |
Member
There was a problem hiding this comment.
oh i see the other comment now!
Member
Author
There was a problem hiding this comment.
So that needs_settling doesn't get affected from the needs_more_settling call.
Lou32Verbose
pushed a commit
to Lou32Verbose/edit
that referenced
this pull request
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50