Add the Document Picker entry to View menu#224
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
Looks good! I'll hold off on merging this for a bit until after I had a chance to merge #179, which in turn I'm holding off until I could address some of the bug reports. Thank you for your patience! |
lhecker
requested changes
May 24, 2025
lhecker
approved these changes
May 24, 2025
lhecker
reviewed
May 24, 2025
| ctx.needs_rerender(); | ||
| } | ||
|
|
||
| if ctx.menubar_menu_checkbox( |
Member
There was a problem hiding this comment.
I just noticed that you picked the wrong type here. This should be menubar_menu_button. Oh well, I'll fix that later. 🙂
diabloproject
pushed a commit
to diabloproject/edit
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
Translations done using an LLM, but I guess it is fine for now 😅