Add underlines to buttons in dialogs that have hotkeys assigned to them

[Treit]

In this dialog, pressing s will save the changes and close the editor.

However, there is no obvious keyboard shortcut for the other two options. I tried the obvious choices like c and d but nothing happened.

Due to #36 it's not clear how to choose these options without using a mouse currently.

[lhecker]

The best approach for this would likely be to add a shortcut_button type to tui.rs and abstract away the existing logic for the menubar:

edit/src/tui.rs

Lines 3118 to 3163 in e8d40f6

	fn menubar_label(&mut self, text: &str, accelerator: char, checked: Option<bool>) {
	if !accelerator.is_ascii_uppercase() {
	self.label("label", text);
	return;
	}
	let mut off = text.len();
	for (i, c) in text.bytes().enumerate() {
	// Perfect match (uppercase character) --> stop
	if c as char == accelerator {
	off = i;
	break;
	}
	// Inexact match (lowercase character) --> use first hit
	if (c & !0x20) as char == accelerator && off == text.len() {
	off = i;
	}
	}
	self.styled_label_begin("label");
	if let Some(checked) = checked {
	self.styled_label_add_text(if checked { "▣ " } else { " " });
	}
	if off < text.len() {
	// Add an underline to the accelerator.
	self.styled_label_add_text(&text[..off]);
	self.styled_label_set_attributes(Attributes::Underlined);
	self.styled_label_add_text(&text[off..off + 1]);
	self.styled_label_set_attributes(Attributes::None);
	self.styled_label_add_text(&text[off + 1..]);
	} else {
	// Add the accelerator in parentheses and underline it.
	let ch = accelerator as u8;
	self.styled_label_add_text(text);
	self.styled_label_add_text("(");
	self.styled_label_set_attributes(Attributes::Underlined);
	self.styled_label_add_text(unsafe { str_from_raw_parts(&ch, 1) });
	self.styled_label_set_attributes(Attributes::None);
	self.styled_label_add_text(")");
	}
	self.styled_label_end();
	self.attr_padding(Rect { left: 0, top: 0, right: 2, bottom: 0 });
	}

FWIW, the shortcut for "Don't Save" is "N" (same as in VS Code). The relevant code is here:

edit/src/bin/edit/draw_editor.rs

Lines 251 to 256 in e8d40f6

	// TODO: This should highlight the corresponding letter in the label.
	if ctx.consume_shortcut(vk::S) {
	action = Action::Save;
	} else if ctx.consume_shortcut(vk::N) {
	action = Action::Discard;
	}

[brandochn]

Hello Guys,

I have sent a PR for this topic.

#275

[deadalusai]

Another solution which tries to maintain the existing "accelerator char" style: #276

[8LWXpg]

For other localizations, the button label should include (S) if it doesn't has that charater.

[deadalusai]

For other localizations, the button label should include (S) if it doesn't has that charater.

In #276 this behavior is inherited from the original "menubutton" implementation: