Update Error Boundary component children prop to accept ReactNode#156
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AppInsightsErrorBoundary component by modifying the type of its children prop from React.ReactElement to React.ReactNode to support a wider variety of React elements.
- Allow broader children types by changing the prop type
- Enhance the flexibility of the Error Boundary component
|
Hello, @Karlie-777 @siyuniu-ms have you been able to take a look at suggested changes within this PR? |
…to-reactelement-when-it-should-accept-reactnode
|
@timagixe Unfortunately, Karlie and Siyu are no longer on the team (for a while now), I'm currently working on an updated release to use the newly published v3.4.1 of Application Insights, and while I don't have the same range of knowledge on React that they had, I don't see anything wrong with this and therefore will push this in (assuming that all tests pass) |
|
@MSNev thanks for merging PR, I have just updated the packages to latest versions, removed fragment around |
Closes #155